Fix too large icon spacing in Qt5 on non-HiDPI screens #14509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Jun 10, 2019
dstansby
approved these changes
Jun 10, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 10, 2019
…n-HiDPI screens
dstansby
added a commit
that referenced
this pull request
Jun 10, 2019
…509-on-v3.1.x Backport PR #14509 on branch v3.1.x (Fix too large icon spacing in Qt5 on non-HiDPI screens)
QuLogic
reviewed
Jun 11, 2019
| @@ -709,7 +709,7 @@ def _init_toolbar(self): | |||
| # Esthetic adjustments - we need to set these explicitly in PyQt5 | |||
| # otherwise the layout looks different - but we don't want to set it if | |||
| # not using HiDPI icons otherwise they look worse than before. | |||
There was a problem hiding this comment.
Shouldn't this comment be removed then?
There was a problem hiding this comment.
The comment is still valuable. The code now does what the comment specifies; and it's good to know why there is the hard-coding for HiDpi. Not sure though if the hard-coding is still necessary, but as long as the following if statement is there, the comment should stay.
There was a problem hiding this comment.
Ah wait sorry, for some reason, I read the diff backwards. Never mind then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using Qt5 on a non-HiDPI screen, the icons have too large spacing. This was explicitly hard-coded. While I don't have a full overview of the HiDPI mechanisms, the comment next to the code already suggests that it should not be applied if not on a HiDPI screen. Also the result justifies the change.
Not sure if this is related to #10891.
before:
after:
