New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for minor ticks in 3d axes. #14626
Conversation
I am surprised that it is this simple to get the feature roughly working. Maybe the api has gotten better at this than when I last looked at this. I still have a vague recollection that I encountered a deeper problem when I looked at this 8 years ago. I do want to try and get this to look right, though. Right now, the minor/major ticks can't be distinguished, and the text labels all overlap each other. The code for handling tick marks and labels all assume major tick semantics. We might need to make a few more changes to get this to look "right". |
There isn't much to be done about overlapping text (you'd get the same with long labels in 2D). I |
a759bd0
to
7cbe0a4
Compare
@ImportanceOfBeingErnest you 👍'd this, do you want to review it? :) or @WeatherGod? |
rebased |
Seems to have really broken tests. |
likely because this crossed wires with the 3d projection change -- regenerated the baseline. |
The actual implementation is shorter than deleting the copies of "Minor ticks are not supported" in the various docstrings...
The actual implementation is shorter than deleting the copies of "Minor
ticks are not supported" in the various docstrings...
Edit: Just a bit longer now that minor ticks are style differently.
PR Summary
PR Checklist