Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for minor ticks in 3d axes. #14626

Merged
merged 1 commit into from Mar 24, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 25, 2019

The actual implementation is shorter than deleting the copies of "Minor
ticks are not supported" in the various docstrings...
Edit: Just a bit longer now that minor ticks are style differently.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@WeatherGod
Copy link
Member

I am surprised that it is this simple to get the feature roughly working. Maybe the api has gotten better at this than when I last looked at this. I still have a vague recollection that I encountered a deeper problem when I looked at this 8 years ago.

I do want to try and get this to look right, though. Right now, the minor/major ticks can't be distinguished, and the text labels all overlap each other. The code for handling tick marks and labels all assume major tick semantics. We might need to make a few more changes to get this to look "right".

@anntzer
Copy link
Contributor Author

anntzer commented Jun 25, 2019

There isn't much to be done about overlapping text (you'd get the same with long labels in 2D). I can probably switch have now switched minor ticks to use a length of xtick.minor.size and a linewidth of xtick.minor.width, but that's all the low lying fruits I can think of.

@anntzer
Copy link
Contributor Author

anntzer commented Nov 20, 2019

@ImportanceOfBeingErnest you 👍'd this, do you want to review it? :) or @WeatherGod?

lib/mpl_toolkits/tests/test_mplot3d.py Outdated Show resolved Hide resolved
@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2020

rebased

@QuLogic
Copy link
Member

QuLogic commented Mar 24, 2020

Seems to have really broken tests.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 24, 2020

likely because this crossed wires with the 3d projection change -- regenerated the baseline.

The actual implementation is shorter than deleting the copies of "Minor
ticks are not supported" in the various docstrings...
@QuLogic QuLogic merged commit ee15e90 into matplotlib:master Mar 24, 2020
@anntzer anntzer deleted the 3dminor branch March 25, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants