Further simplify the flow of pdf text output. #14886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
pdftext
branch
4 times, most recently
from
e8c9162
to
f28bffc
Compare
QuLogic
reviewed
Jul 26, 2019
... and, as a side benefit, correctly kern between 1-byte and 2-byte chunks.
... to avoid confusion with the unicode codepoint. FreeType's doc mostly uses "glyph index", except that the function to get it is called FT_Get_Char_Index...
|
Added a second commit renaming "char_idx" to "glyph_idx" throughout, as this patch is a bit less confusing with that (avoids confusion between unicode codepoint and glyph indices); fwiw freetype's doc appears to use "glyph index"... except that the function to retrieve them is FT_Get_Char_Index, but heh. |
QuLogic
approved these changes
Jul 26, 2019
ruidazeng
approved these changes
Jul 26, 2019
timhoffm
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
... and, as a side benefit, correctly kern between 1-byte and 2-byte
chunks.
followup to #14872.
PR Checklist