PEP8ify some variable names. #15204
Merged
PEP8ify some variable names. #15204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 6, 2019
lib/matplotlib/axes/_subplots.py
Outdated
| ---------- | ||
| fig : `matplotlib.figure.Figure` | ||
|
|
||
| *args : tuple (*nrows*, *ncols*, *index*) |
There was a problem hiding this comment.
Suggested change
| *args : tuple (*nrows*, *ncols*, *index*) | |
| *args : tuple (*nrows*, *ncols*, *index*) or int |
I think that should be mentioned, even though the int has very special semantics.
| decimal integer *numRows* * 100 + *numCols* * 10 + *plotNum*. | ||
| fig : `matplotlib.figure.Figure` | ||
|
|
||
| *args : tuple (*nrows*, *ncols*, *index*) |
There was a problem hiding this comment.
Suggested change
| *args : tuple (*nrows*, *ncols*, *index*) | |
| *args : tuple (*nrows*, *ncols*, *index*) or int |
NelleV
approved these changes
Sep 7, 2019
nrows/ncols is already used as parameter names in subplots() so standardizing on them seems good enough. Note that the docstring of SubplotBase was previously incorrect: one didn't need `numRows <= numCols <= plotNum < 10`, just that all three be single-digit.
timhoffm
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrows/ncols is already used as parameter names in subplots() so
standardizing on them seems good enough.
Note that the docstring of SubplotBase was previously incorrect:
one didn't need
numRows <= numCols <= plotNum < 10, just that allthree be single-digit.
PR Summary
PR Checklist