Shorten RendererWx.get_wx_font. #15292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Sep 18, 2019
QuLogic
reviewed
Sep 26, 2019
| self.fontd[key] = font | ||
|
|
||
| self.fontd[key] = font = wx.Font( # Cache the font and gc. | ||
| pointSize=round(self.points_to_pixels(prop.get_size_in_points())), |
There was a problem hiding this comment.
This doesn't round the same, but I'm not sure if it's important:
In [9]: for i in range(10):
...: i = i + 0.5
...: print(i, round(i), int(i + 0.5))
...:
0.5 0 1
1.5 2 2
2.5 2 3
3.5 4 4
4.5 4 5
5.5 6 6
6.5 6 7
7.5 8 8
8.5 8 9
9.5 10 10There was a problem hiding this comment.
Actually, upon further testing wx.Font accepts floats just fine here so I just dropped the rounding (after all freetype accepts sizes in multiples of (1/64) so there's no reason to drop that info...).
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jan 29, 2021
This is a very-small partial revert of matplotlib#15292, which claimed that wx supports floats, but this no longer appears to be the case with Python 3.10, and looking at the C++ class constructor [1], should not have ever been supported. [1] https://docs.wxwidgets.org/3.0/classwx_font.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist