Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom logging in wx by stdlib logging. #15294

Merged
merged 1 commit into from Sep 18, 2019
Merged

Replace custom logging in wx by stdlib logging. #15294

merged 1 commit into from Sep 18, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 18, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Sep 18, 2019
View reviewed changes
lib/matplotlib/backends/backend_wx.py Outdated
@@ -198,7 +199,7 @@ def __init__(self, bitmap, dpi):
alternative="wxagg", addendum="See the Matplotlib usage FAQ for "
"more info on backends.")
RendererBase.__init__(self)
DEBUG_MSG("__init__()", 1, self)
_log.debug("%s - __init__()", self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use %s with type(self) or %r. The plain string representation may be verbose (though it probably is not here - didn't check).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@jklymak jklymak merged commit 030157c into matplotlib:master Sep 18, 2019
@anntzer anntzer deleted the wxlog branch September 18, 2019 22:36
@QuLogic QuLogic added this to the v3.3.0 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anntzer @jklymak @timhoffm @QuLogic