Autoscale for ax.arrow() #15392
Merged
Autoscale for ax.arrow() #15392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Oct 9, 2019
choyiny
force-pushed
the
arrow-autoscale
branch
2 times, most recently
from
90794e4
to
735996f
Compare
|
Some weird error about test timeout in latest travis build. Force pushing to restart tests. |
QuLogic
approved these changes
Mar 23, 2020
choyiny
force-pushed
the
arrow-autoscale
branch
from
735996f
to
f4e7d6c
Compare
|
Not sure what is happening with the tests, but they don't seem to relate to my change. |
|
Sorry for the inconvenience. There was an incorrect merge causing CI to fail (#16897). Can you please rebase on top of master? |
|
No need, a close/open should do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When ax.arrow() is called, a FancyArrow object is being added to the current axes as an artist and not a patch. So when autoscale_view is called, which loops through all Patches and scales the view based on the minimum and maximum of those, the FancyArrow isn't being considered.
The solution is a two-step process. First, we have to add the arrow as a Patch, and second, we have to lazily call autoscale_view() after adding it on the axes.
Part of a course at University of Toronto with @atafliovich.
Resolves #12712
Takes over #13788
PR Checklist