Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: typo in attribute lookup #15422

Merged
merged 1 commit into from Oct 16, 2019
Merged

FIX: typo in attribute lookup #15422

merged 1 commit into from Oct 16, 2019

Conversation

tacaswell
Copy link
Member

The attribute is _is_drawing not ._is_drawing

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell
FIX: typo in attribute lookup
9f766a7 
The attribute is `_is_drawing` not `._is_drawing`
@tacaswell tacaswell added this to the v2.2.5 milestone Oct 15, 2019
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 15, 2019
timhoffm
timhoffm approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build errors are in the setup of the CI and unrelated to this PR.

@timhoffm timhoffm merged commit 8ea326c into matplotlib:master Oct 16, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
@timhoffm
Backport PR matplotlib#15422: FIX: typo in attribute lookup
572fe8f
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 16, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
@timhoffm
Backport PR matplotlib#15422: FIX: typo in attribute lookup
b343892
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 16, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
@timhoffm
Backport PR matplotlib#15422: FIX: typo in attribute lookup
7e44b95
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 16, 2019
Merged
@tacaswell tacaswell deleted the fix_qt_typo branch October 16, 2019 12:45
tacaswell added a commit that referenced this pull request Oct 16, 2019
@tacaswell
Merge pull request #15424 from meeseeksmachine/auto-backport-of-pr-15…
5102af3 
…422-on-v3.1.x

Backport PR #15422 on branch v3.1.x (FIX: typo in attribute lookup)
jklymak added a commit that referenced this pull request Oct 16, 2019
@jklymak
Merge pull request #15423 from meeseeksmachine/auto-backport-of-pr-15…
eda29e1 
…422-on-v2.2.x

Backport PR #15422 on branch v2.2.x (FIX: typo in attribute lookup)
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Oct 17, 2019
@timhoffm
Merge pull request matplotlib#15422 from tacaswell/fix_qt_typo
6947f61 
FIX: typo in attribute lookup
tacaswell added a commit that referenced this pull request Oct 19, 2019
@tacaswell
Merge pull request #15425 from meeseeksmachine/auto-backport-of-pr-15…
762e979 
…422-on-v3.2.x

Backport PR #15422 on branch v3.2.x (FIX: typo in attribute lookup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tacaswell @jklymak @timhoffm