Handle upcoming deprecation of np.float. #15694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy plans to deprecate np.float in favor of float; remove the few remaining usages of np.float in the codebase. Actually the Bbox constructor already converts its argument using `np.asarray(..., dtype=float)` so we don't need to bother explicitly casting the argument to a float array at the call site.
tacaswell
approved these changes
Nov 14, 2019
eric-wieser
reviewed
Nov 14, 2019
Comment on lines
-766
to
+771
| return Bbox(np.array([[0.0, 0.0], [1.0, 1.0]], float)) | ||
| return Bbox([[0, 0], [1, 1]]) | ||
|
|
||
| @staticmethod | ||
| def null(): | ||
| """Create a new null `Bbox` from (inf, inf) to (-inf, -inf).""" | ||
| return Bbox(np.array([[np.inf, np.inf], [-np.inf, -np.inf]], float)) | ||
| return Bbox([[np.inf, np.inf], [-np.inf, -np.inf]]) |
There was a problem hiding this comment.
I assume you're aware that numpy doesn't care about these lines, and you're just doing cleanup while you're here?
|
Follows on from #8996. Guess I missed some. |
timhoffm
approved these changes
Nov 14, 2019
QuLogic
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy plans to deprecate np.float in favor of float (numpy/numpy#14882); remove the few
remaining usages of np.float in the codebase.
Actually the Bbox constructor already converts its argument using
np.asarray(..., dtype=float)so we don't need to bother explicitlycasting the argument to a float array at the call site.
PR Summary
PR Checklist