Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dviread docs. #15792

Merged
merged 1 commit into from Dec 1, 2019
Merged

Cleanup dviread docs. #15792

merged 1 commit into from Dec 1, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 29, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Nov 30, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples should be after notes (https://numpydoc.readthedocs.io/en/latest/format.html#method-docstrings).

@anntzer
Copy link
Contributor Author

anntzer commented Dec 1, 2019

fixed

timhoffm
timhoffm approved these changes Dec 1, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@anntzer anntzer merged commit e3bf17e into matplotlib:master Dec 1, 2019
@anntzer anntzer deleted the dviread-docs branch December 1, 2019 18:00
@QuLogic QuLogic added this to the v3.3.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anntzer @timhoffm @QuLogic