Fix legend dragging. #16105
Merged
Fix legend dragging. #16105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
added
the
Release critical
timhoffm
reviewed
Jan 5, 2020
Without this PR, after
```
plot([1, 2], label="foo"); legend().set_draggable(True)
```
when dragging the legend, releasing the mouse button results in
```
Traceback (most recent call last):
File ".../matplotlib/cbook/__init__.py", line 236, in process
func(*args, **kwargs)
File ".../matplotlib/offsetbox.py", line 1716, in on_release
self.finalize_offset()
File ".../matplotlib/legend.py", line 78, in finalize_offset
{"loc": self._update_loc, "bbox": self._bbox_to_anchor},
AttributeError: 'DraggableLegend' object has no attribute '_bbox_to_anchor'
```
See comment in code for more explanations.
A test may be nice but tricky to write...
jklymak
approved these changes
Jan 6, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 6, 2020
|
I think in the future style fix PRs like #15086 should have 100% test coverage. If some part can't be tested, maybe make it its own PR? |
|
sounds fair |
QuLogic
added a commit
that referenced
this pull request
Jan 7, 2020
…105-on-v3.2.x Backport PR #16105 on branch v3.2.x (Fix legend dragging.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, after
when dragging the legend, releasing the mouse button results in
See comment in code for more explanations.
A test may be nice but tricky to write...
Came in in #15086, so RC for 3.2.
PR Summary
PR Checklist