change handling of legend labels which are None #1611

Merged
merged 2 commits into from Jan 16, 2013

Conversation

Projects
None yet
4 participants
Contributor

segasai commented Dec 19, 2012

Fixes #1610

Owner

mdboom commented Dec 19, 2012

+1

Member

WeatherGod commented Dec 19, 2012

Travis build failure is a dud (timeout error while downloading PIL). It only occurred for the py2.7 test.

Note that this PR is against master branch only. Shall we cherry-pick to v1.2.x branch?

Contributor

segasai commented Dec 19, 2012

I think, it is worth a patch for 1.2.x branch. (I won't do this cherry-picking myself, because I'm not sure what's the best way to do it on github).

Member

dmcdougall commented Dec 30, 2012

The preferred method is to branch off of v1.2.x and patch the maintenance branch. Then when v1.2.x is merged into master the new changes will apply to master.

@segasai Are you comfortable doing this?

dmcdougall was assigned Dec 30, 2012

Owner

mdboom commented Jan 16, 2013

No worries. I'll merge this and cherry-pick it back to 1.2.x myself.

@mdboom mdboom added a commit that referenced this pull request Jan 16, 2013

@mdboom mdboom Merge pull request #1611 from segasai/master
change handling of legend labels which are None
a9dcdfd

@mdboom mdboom merged commit a9dcdfd into matplotlib:master Jan 16, 2013

1 check failed

default The Travis build failed
Details

@mdboom mdboom added a commit that referenced this pull request Jan 16, 2013

@mdboom mdboom Merge pull request #1611 from segasai/master
change handling of legend labels which are None
df4b02d

dmcdougall referenced this pull request Jan 18, 2013

Closed

plotting legends none #1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment