Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe RGBAxes examples. #16741

Merged
merged 1 commit into from Mar 13, 2020
Merged

Dedupe RGBAxes examples. #16741

merged 1 commit into from Mar 13, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 12, 2020

simple_rgb is essentially the second case of demo_axes_rgb, so remove
the former. Also small cleanups to demo_axes_rgb: get_demo_image can be
folded into get_rgb; demo_rgb2 doesn't need to return the axes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Copy link
Member

QuLogic commented Mar 12, 2020

I think there are some cross-references here:

/home/circleci/project/doc/tutorials/toolkits/axes_grid.rst:: WARNING: image file not readable: tutorials/toolkits/../../gallery/axes_grid1/images/sphx_glr_simple_rgb_001.png

simple_rgb is essentially the second case of demo_axes_rgb, so remove
the former.  Also small cleanups to demo_axes_rgb: get_demo_image can be
folded into get_rgb; demo_rgb2 doesn't need to return the axes.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 12, 2020

ok, swapped the order of the examples and moved the ticks-to-white to the second one (previously first one) to keep the "simple" case for display in the tutorial.

@QuLogic QuLogic merged commit 2883c90 into matplotlib:master Mar 13, 2020
@anntzer anntzer deleted the rgbex branch March 13, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants