TST: update default junit_family #16944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest 6 will be moving to this by default and azure supports this format so might as well move to the future now. This causes exceptions from pytest if we try to set it in conftest.py with the markers
tacaswell
force-pushed
the
tst_update_junit_schema
branch
from
7455f54
to
e917370
Compare
|
ok, so pytest does not like that at all (we are hitting exceptions about pytest internals...). |
|
But CI passed? |
Sorry, that was referring to the now force-pushed out of existence first attempt of setting the junit family in conftest. |
timhoffm
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
pytest 6 will be moving to this by default and azure supports this
format so might as well move to the future now.