Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation writer fallback. #16966

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix animation writer fallback. #16966

merged 1 commit into from Mar 30, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 30, 2020

Getting the next available writer was done incorrectly.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix animation writer fallback.
3ab7641 
Getting the next available writer was done incorrectly.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation labels Mar 30, 2020
@anntzer anntzer added this to the v3.2.2 milestone Mar 30, 2020
@anntzer anntzer mentioned this pull request Mar 30, 2020
Merged
6 tasks
@tacaswell
Copy link
Member

closes #16965

@QuLogic QuLogic merged commit 84e872d into matplotlib:master Mar 30, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 30, 2020
@QuLogic @meeseeksmachine
Backport PR matplotlib#16966: Fix animation writer fallback.
a14050a
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 30, 2020
Merged
@anntzer anntzer deleted the animfallback branch March 30, 2020 22:25
QuLogic added a commit that referenced this pull request Mar 31, 2020
@QuLogic
Merge pull request #16969 from meeseeksmachine/auto-backport-of-pr-16…
b3e8fca 
…966-on-v3.2.x

Backport PR #16966 on branch v3.2.x (Fix animation writer fallback.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: animation
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anntzer @tacaswell @timhoffm @QuLogic