Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving nbAgg figure after a partial blit #17027

Merged
merged 1 commit into from Apr 24, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 4, 2020

PR Summary

While testing out #13971, I realized that it was making an empty blit on click, and that if I hit Save after that, the result would be empty. Also, hitting the Home button would create an image that was a weird mix of the old and new views (whatever the blit looked like.)

Fortunately, this is already fixed in ipympl, so I can just grab the fix from there. This seems to have been broken since forever.

Waiting on the JS re-formatting PR.

PR Checklist

  • Has Pytest style unit tests
  • [N/A] Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.3.0 milestone Apr 23, 2020
@tacaswell tacaswell merged commit f374bec into matplotlib:master Apr 24, 2020
@QuLogic QuLogic deleted the nbagg-blit branch April 24, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants