Fix saving nbAgg figure after a partial blit #17027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
While testing out #13971, I realized that it was making an empty blit on click, and that if I hit Save after that, the result would be empty. Also, hitting the Home button would create an image that was a weird mix of the old and new views (whatever the blit looked like.)
Fortunately, this is already fixed in ipympl, so I can just grab the fix from there. This seems to have been broken since forever.
Waiting on the JS re-formatting PR.
PR Checklist