Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most instances of D404 ("docstring should not start with 'this'"). #17148

Merged
merged 1 commit into from Apr 15, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 15, 2020

... and associated rewordings.

(xref #17145 (comment)).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer changed the title Fix most instances of D404 ("docstring should not start with 'this'). Fix most instances of D404 ("docstring should not start with 'this'"). Apr 15, 2020
This method can only be used after an initial draw which
caches the renderer. It is used to efficiently update Axes
data (axis ticks, labels, etc are not updated).
It is used to efficiently redraw Axes data (axis ticks, labels, etc.,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is used to efficiently redraw Axes data (axis ticks, labels, etc.,
Efficiently redraw Axes data (axis ticks, labels, etc.,

@@ -1026,9 +1026,9 @@ def Destroy(self, *args, **kwargs):

class FigureManagerWx(FigureManagerBase):
"""
This class contains the FigureCanvas and GUI frame
A class contains the FigureCanvas and GUI frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A class contains the FigureCanvas and GUI frame.
Container/controller for the FigureCanvas and the GUI frame.

This function actually creates the wind barbs. *u* and *v*
are components of the vector in the *x* and *y* directions,
respectively.
Actually creates the wind barbs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Actually creates the wind barbs.
Create wind barbs.

@@ -1,5 +1,5 @@
"""
This module is to support the *bbox_inches* parameter in `.Figure.savefig`.
Support module for the *bbox_inches* parameter in `.Figure.savefig`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Support module for the *bbox_inches* parameter in `.Figure.savefig`.
Helper module for the *bbox_inches* parameter in `.Figure.savefig`.

I have the impression that "helper module" is more common than "support module", but not sure.

Comment on lines 214 to 215
The base class of all bounding boxes, which provides read-only access
to its data. A mutable bounding box is provided by the `Bbox` class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The base class of all bounding boxes, which provides read-only access
to its data. A mutable bounding box is provided by the `Bbox` class.
The base class of all bounding boxes.
This box is immutable. See `Bbox` for a mutable bounding box.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 15, 2020

thanks, all handled.

@timhoffm timhoffm merged commit 3b111ac into matplotlib:master Apr 15, 2020
@anntzer anntzer deleted the d404 branch April 15, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants