BUG: Picking vertical line broken #17489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually #17282 is just wrong because either u or dx, dy still need to be divided by Lsquare_norm, so let's just revert it. Thanks for pointing this out. |
anntzer
added
the
Release critical
This reverts commit fdf07f5.
|
Revert pushed |
QuLogic
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17282 introduced a bug where a vertical line could no longer be picked properly. This test is a minimal example showing it, it passes on 2518777 but fails on fdf07f5 .
@anntzer #17282 was yours, any interest in fixing this? If not, I can try to understand why it fails but the old code works. It wasn't immediately obvious to me from looking at the code.