markerfacecolor should not override fillstyle='none' in plot() #17544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Jun 3, 2020
timhoffm
force-pushed
the
plot-fillstyle-none
branch
from
d891bc2
to
df6a138
Compare
|
Test added. |
QuLogic
reviewed
Jun 4, 2020
timhoffm
force-pushed
the
plot-fillstyle-none
branch
from
df6a138
to
b372b8b
Compare
timhoffm
force-pushed
the
plot-fillstyle-none
branch
from
b372b8b
to
c4fa6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously using
plt.plot([1, 3, 2], marker=MarkerStyle('o', fillstyle='none'), markerfacecolor='red')resulted in the markers to be filled red. This does not make sense as it silently discards fillstyle='none'.Instead, the markers should still be unfilled. Markerfacecolor is already ignored for unfillable markers like 'x'. The same should hold for unfilled marker that could potentially be filled but are explicitly set to be unfilled.
The effect of this can be seen in the 'none' markers being filled at
https://matplotlib.org/devdocs/gallery/lines_bars_and_markers/marker_reference.html#marker-fill-styles. (Here it's triggered with keyword argument fillstyle='none', but the code path is the same).