New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh what's new page for 3.3.0 #17858
Conversation
This totally messed up the page ToC.
Generally, this is things-with-a-plot, then things-with-an-example, then some random other stuff, and finally groups of things-with-something-in-common (e.g., all rcParams together).
This prevents overflow of the ToC in the sidebar.
Added more plots, added more entries (like turbo, pie normalize, etc.). You may wish to review the commits separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all my nitpicks, I really do 😍 this what's new.
Big picture, can you group all the RCParam stuff under a subheading, and same /w all the font/text stuff. Maybe also the ticks & labels stuff (the titling, coloring. formatting, etc). the semantic and sharing stuff is all axes creation/management.
``canvas.mpl_connect("button_press_event", button_press_handler)``, rather than | ||
having to write wrapper functions that fill in the (now optional) *canvas* and | ||
*toolbar* parameters. | ||
Instead, they are implemented using vanilla JavaScript. Please report any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plain Javascript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vanilla JS is a 'thing'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's why I was kinda confused about this terminology here, didn't grok til just now that that's a joke page.
rcParams are already in a subheading; it's just such a low level that our styling doesn't make it super obvious. |
I made some edits except for the things I don't know about noted above. I haven't done any of the requested re-ordering yet. Do you mean group as in move together, or add more headings? |
Both - group like things together under a subheading, like paths and 3d already have. |
My new order is now:
followed by these, which have not changed, so I'm not going to copy&paste all the subheadings:
So now I'm wondering where to put:
|
I think its OK to have a "other changes" section... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree w/ @jklymak & also most of the rest of these have to do w/ plot types:
- New Axes.axline method
- imshow now coerces 3D arrays with depth 1 to 2D
- Better control of Axes.pie normalization
And d
- Dates use a modern epoch
- Lines now accept MarkerStyle instances as input
# For the purposes of keeping the documentation build warning-free, and | ||
# future proof for when the deprecation is made permanent, we pass | ||
# *normalize* here explicitly anyway. | ||
ax[1, 0].pie(x, autopct='%1.2f%%', labels=label(x), normalize=False) | ||
ax[1, 0].set_title('normalize unspecified\nsum(x) < 1') | ||
ax[1, 1].pie(x * 10, autopct='%1.2f%%', labels=label(x * 10), | ||
normalize=True) | ||
ax[1, 1].set_title('normalize unspecified\nsum(x) > 1') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this need to be in the what's new?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What part specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code and especially this note:
For the purposes of keeping the documentation build warning-free, and
# future proof for when the deprecation is made permanent, we pass
# normalize here explicitly anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm confused; didn't you ask for code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😦 sorry for the confusion, I did ask for code and the note threw me 'cause I read it as explaining a deprecated feature rather than a new one. Maybe movinng the comment under the code could make it clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, well this is showing deprecated behaviour as comparison with the new explicit one, but because it's deprecated, I had to use the new explicit one in the code. It's labelled with the old way in the figure though. (Note, this code isn't shown by default.) I could remove it or change the comment description a little?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, if the code/comment isn't shown than it's good enough...
I pushed the re-ordering and used the following sections for the remaining items:
I'm not super-happy with that first section name, so suggestions welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting up w/ my comments - it's now coherent enough to make me happy.
@tacaswell said it's docs and therefore can go in w/ one merge (or even a self merge 🤷 |
…858-on-v3.3.x Backport PR #17858 on branch v3.3.x (Refresh what's new page for 3.3.0)
PR Summary
This fixes some minor things (see commit messages), but major thing is the re-ordering.
Generally, this is things-with-a-plot, then things-with-an-example, then some random other stuff, and finally groups of things-with-something-in-common (e.g., all rcParams together).
Now, I'll be adding in plots, but this is maybe large enough to review already.
PR Checklist