Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support data reference for hexbin() parameter C #18103

Merged
merged 1 commit into from Jul 29, 2020
Merged

Support data reference for hexbin() parameter C #18103

merged 1 commit into from Jul 29, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

Closes #18097.

@timhoffm timhoffm added this to the v3.4.0 milestone Jul 28, 2020
@jklymak
Copy link
Member

jklymak commented Jul 28, 2020

Easy! But hard to tell if it worked - is it OK just to assume the preprocessor works because it works on other functions?

@timhoffm
Copy link
Member Author

I'll answer that with a yes. The preprocessor itself is tested. We don't want to test every variant of possible calls to the plotting functions.

@jklymak
Copy link
Member

jklymak commented Jul 29, 2020

Sure, just wanted to make sure it was tested somewhere.

dopplershift
dopplershift approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dopplershift
Copy link
Contributor

Failing tests are:

lib/matplotlib/tests/test_animation.py::test_draw_frame
lib/matplotlib/tests/test_arrow_patches.py::test_fancyarrow[pdf]

They're unrelated and passing here for me on OSX on Python 3.8...so do we ignore or re-run?

@jklymak
Copy link
Member

jklymak commented Jul 29, 2020

Those also failed on #18100. So I don't think it is these PRs, though its possible it is a previous PR that has worked its way into master...

@jklymak jklymak merged commit 97e525c into matplotlib:master Jul 29, 2020
@timhoffm timhoffm deleted the hexbin-data branch July 29, 2020 08:10
@QuLogic QuLogic mentioned this pull request Mar 18, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
API: consistency New feature
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow hexbin to use a string for parameter C to refer to column in data (DataFrame)
3 participants
@timhoffm @jklymak @dopplershift