Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depth shading when edge/facecolor is none. #18505

Merged
merged 1 commit into from Sep 17, 2020
Merged

Fix depth shading when edge/facecolor is none. #18505

merged 1 commit into from Sep 17, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 17, 2020

PR Summary

This causes a crash when re-broadcasting with the colour that is then (0, 4)-shaped.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Fix depth shading when edge/facecolor is none.
22627ca 
This causes a crash when re-broadcasting with the colour that is then
(0, 4)-shaped.
@QuLogic QuLogic added this to the v3.3.3 milestone Sep 17, 2020
@jklymak jklymak merged commit 641d2fa into matplotlib:master Sep 17, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 17, 2020
@jklymak @meeseeksmachine
Backport PR matplotlib#18505: Fix depth shading when edge/facecolor i…
a7ea044 
…s none.
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 17, 2020
Merged
dstansby added a commit that referenced this pull request Sep 17, 2020
@dstansby
Merge pull request #18509 from meeseeksmachine/auto-backport-of-pr-18…
c18921a 
…505-on-v3.3.x

Backport PR #18505 on branch v3.3.x (Fix depth shading when edge/facecolor is none.)
@QuLogic QuLogic deleted the empty-depthshading branch September 17, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: mplot3d
Projects
None yet
Milestone
v3.3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QuLogic @jklymak @dstansby