Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Border for color examples #18672

Merged
merged 2 commits into from Oct 6, 2020
Merged

Conversation

jeetvora331
Copy link
Contributor

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

303
202
101

@jklymak
Copy link
Member

jklymak commented Oct 6, 2020

I think we already had a PR that did this? I guess that was #16467 and it didn't actually implement the border color...

@jklymak jklymak linked an issue Oct 6, 2020 that may be closed by this pull request
@story645
Copy link
Member

story645 commented Oct 6, 2020

@jklymak yeah there was debate around borders so we decided was easier to just leave it to another PR.
Thanks @jeetvora331, I think the light gray is neutral enough that it's not messing w/ the color perception too much.

@jklymak jklymak merged commit d0753c0 into matplotlib:master Oct 6, 2020
@jklymak
Copy link
Member

jklymak commented Oct 6, 2020

Thanks @jeetvora331 !

@QuLogic QuLogic added this to the v3.4.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

named color examples need borders
4 participants