Use selectfont instead of findfont + scalefont + setfont in PostScript. #18894
Conversation
anntzer
changed the title
`key scale selectfont` is literally defined as `key findfont scale scalefont setfont`, but "almost always more efficient" (according to the spec). Also unify the AFM and non-AFM codepaths. I decided to just change the behavior of `set_font` in the AFM case as it seems unlikely people were relying on that; the alternative would be to just completely deprecate `set_font` in favor of a new `_set_font` with the new behavior, which in fact seems more disruptive...
| self.set_color(*gc.get_rgb()) | ||
| ps_name = (font.postscript_name | ||
| .encode("ascii", "replace").decode("ascii")) | ||
| self.set_font(ps_name, prop.get_size_in_points()) |
There was a problem hiding this comment.
Putting this here means the font change will happen before the gsave, which is flipped from how it worked in the useafm case before this.
There was a problem hiding this comment.
I believe that's fine, and in fact that's how set_font is supposed to work (its save parameter basically assumes that it is setting the font globally (outside of any gsave block) so that it know when it needs to reset the font or not.
|
For future reference postscript spec: https://www.adobe.com/content/dam/acom/en/devnet/actionscript/articles/psrefman.pdf One concern I had was that |
PR Summary
key scale selectfontis literally defined askey findfont scale scalefont setfont,but "almost always more efficient" (according to the spec).
Also unify the AFM and non-AFM codepaths.
I decided to just change the behavior of
set_fontin the AFM case asit seems unlikely people were relying on that; the alternative would be
to just completely deprecate
set_fontin favor of a new_set_fontwith the new behavior, which in fact seems more disruptive...
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).