Cleanup code for format processing #19291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail with 'none'. Trying 'None'. |
timhoffm
force-pushed
the
cleanup-fmt-processing
branch
from
c73d353
to
3de76fa
Compare
anntzer
reviewed
Jan 14, 2021
timhoffm
force-pushed
the
cleanup-fmt-processing
branch
from
3de76fa
to
b8f070e
Compare
timhoffm
force-pushed
the
cleanup-fmt-processing
branch
from
b8f070e
to
9d4825b
Compare
anntzer
approved these changes
Jan 18, 2021
QuLogic
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Better to be explicit with 'none' and not pretend to have a sentinel, that actually has hidden meaning.
See #19277 (comment) for motivation and context.