FIX: pass colorbar.set_ticklabels down to long_axis #20758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
force-pushed
the
fix-pass-colorbar-set_ticklabels
branch
2 times, most recently
from
490ef8e
to
0a66897
Compare
jklymak
force-pushed
the
fix-pass-colorbar-set_ticklabels
branch
from
3377790
to
198a0d7
Compare
|
I think this is a start, but we do have a bit of funkiness about |
timhoffm
approved these changes
Jul 28, 2021
QuLogic
reviewed
Jul 29, 2021
Comment on lines
-827
to
-828
| The tick positions can be hard-coded by an array of values; or | ||
| they can be defined by a `.Locator`. Setting to *None* reverts |
There was a problem hiding this comment.
Accepting a Locator is (intentionally?) no longer documented.
There was a problem hiding this comment.
Right, I didn't want to break API, however, axis.set_ticks does not take a locator so far as I can tell.
jklymak
force-pushed
the
fix-pass-colorbar-set_ticklabels
branch
from
198a0d7
to
d19c8b7
Compare
QuLogic
reviewed
Jul 29, 2021
jklymak
force-pushed
the
fix-pass-colorbar-set_ticklabels
branch
from
d19c8b7
to
cd5e222
Compare
jklymak
force-pushed
the
fix-pass-colorbar-set_ticklabels
branch
from
cd5e222
to
c64c852
Compare
QuLogic
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #20296
colorbar.set_ticklabelsis now just an alias tocolorbar._long_axis().set_ticklabelsexcept it also has a deprecated kwarg.Not sure if this really needs an API change or not - its just making the
set_ticklabelsthe same as it is onaxis.set_ticklabels.Also updated
colorbar.set_ticksto be the same as the axis command.