Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: spanning subfigures #21481

Merged
merged 1 commit into from Oct 30, 2021
Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Oct 28, 2021

PR Summary

Closes #21480

In that issue, gridspec indexing with open slices fails with constrained_layout for subfigures...

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Oct 28, 2021
@jklymak jklymak added this to the v3.5.1 milestone Oct 28, 2021
lib/matplotlib/_layoutgrid.py Outdated Show resolved Hide resolved
lib/matplotlib/_layoutgrid.py Outdated Show resolved Hide resolved
@QuLogic
Copy link
Member

QuLogic commented Oct 29, 2021

Did you mean to force push something? Seems like there are double commits.

@jklymak
Copy link
Member Author

jklymak commented Oct 30, 2021

squashed!

@QuLogic QuLogic merged commit b09aad2 into matplotlib:main Oct 30, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 30, 2021
@QuLogic QuLogic modified the milestones: v3.5.1, v3.5.0 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Subfigure breaks for some Gridspec slices when using constrained_layout
3 participants