Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword margins docstrings, and fix bounds on zmargin values. #21536

Merged
merged 1 commit into from Nov 4, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 3, 2021

The bounds on zmargin values can match those on x/ymargins.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

The bounds on zmargin values can match those on x/ymargins.
@timhoffm
Copy link
Member

timhoffm commented Nov 4, 2021

Do you want this as a fix in 3.5 or is 3.6 ok?

@anntzer
Copy link
Contributor Author

anntzer commented Nov 4, 2021

I personally don't care, 3.6 is fine.

@timhoffm timhoffm added this to the v3.6.0 milestone Nov 4, 2021
@timhoffm timhoffm merged commit f96eb63 into matplotlib:main Nov 4, 2021
@anntzer anntzer deleted the md branch November 4, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants