Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gtk3 full_screen_toggle more robust against external changes. #21590

Merged
merged 1 commit into from Nov 10, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 10, 2021

The fullscreen state can also change via the window manager, so read the
state instead of trying to keep an internal flag. All other backends
already use a similar strategy.

(self.window is a GtkWindow, whereas self.window.get_window() is a
GdkWindow...)

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

The fullscreen state can also change via the window manager, so read the
state instead of trying to keep an internal flag.  All other backends
already use a similar strategy.

(`self.window` is a GtkWindow, whereas `self.window.get_window()` is a
GdkWindow...)
@timhoffm timhoffm added this to the v3.6.0 milestone Nov 10, 2021
@timhoffm timhoffm merged commit 98997ee into matplotlib:main Nov 10, 2021
@anntzer anntzer deleted the 3fs branch November 11, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants