Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused bbox arg to _convert_agg_to_wx_bitmap. #21867

Merged
merged 1 commit into from Dec 6, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 5, 2021

This arg is unused since 744b7f8; we only need to clip when actually
blitting to the destination bitmap, not when first converting the agg
buffer to a bitmap. Also make the conversion function directly take an
rgba buffer as input and rename it, as it isn't really agg-specific.

Also switch the construction of MemoryDC to directly pass in the
Selected bitmap as arg, rather that having a separate SelectObject call
(this is supported all the way back since wx3).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

This arg is unused since 744b7f8; we only need to clip when actually
blitting to the destination bitmap, not when first converting the agg
buffer to a bitmap.  Also make the conversion function directly take an
rgba buffer as input and rename it, as it isn't really agg-specific.

Also switch the construction of MemoryDC to directly pass in the
Selected bitmap as arg, rather that having a separate SelectObject call
(this is supported all the way back since wx3).
@tacaswell tacaswell added this to the v3.6.0 milestone Dec 6, 2021
@tacaswell tacaswell merged commit 632260e into matplotlib:main Dec 6, 2021
@anntzer anntzer deleted the wxbitmap branch December 6, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants