Small cleanup to font handling in agg. #22467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 13, 2022
QuLogic
reviewed
Feb 15, 2022
Rename _get_agg_font to _prepare_font, as it doesn't really do anything agg-specific. Fix its docstring. Rename the *prop* arg to *font_prop*, which makes its type clear in the context (and avoids having to mention it in the docstring, thus keeping the docstring single-line). _get_agg_font/_prepare_font never returns None (e.g. we always call `clear` on the font instance) so skip a None check in draw_text. Skip a few temporary variables, which don't add much to legibility.
QuLogic
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename _get_agg_font to _prepare_font, as it doesn't really do
anything agg-specific. Fix its docstring. Rename the prop arg to
font_prop, which makes its type clear in the context (and avoids
having to mention it in the docstring, thus keeping the docstring
single-line).
_get_agg_font/_prepare_font never returns None (e.g. we always call
clearon the font instance) so skip a None check in draw_text.Skip a few temporary variables, which don't add much to legibility.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).