Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds _enum qualifier for QColorDialog.ShowAlphaChannel. Closes #22471. #22479

Merged
merged 1 commit into from Feb 17, 2022

Conversation

MAKOMO
Copy link
Contributor

@MAKOMO MAKOMO commented Feb 17, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell added this to the v3.5.2 milestone Feb 17, 2022
@tacaswell tacaswell merged commit c2f39dd into matplotlib:main Feb 17, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 17, 2022
@timhoffm
Copy link
Member

Thanks @MAKOMO and congratulations on your first contribution to Matplotlib. 🎉 We hope to see you back!

QuLogic added a commit that referenced this pull request Feb 17, 2022
…479-on-v3.5.x

Backport PR #22479 on branch v3.5.x (adds _enum qualifier for QColorDialog.ShowAlphaChannel. Closes #22471.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants