Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak dependency checking in doc/conf.py. #22552

Merged
merged 1 commit into from Feb 24, 2022
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 24, 2022

  • Autogen most of the checked list.
  • Replace outdated pydata_sphinx_theme entry.
  • matplotlib and its dependency pillow don't need to be explicitly
    listed, as we already import matplotlib at the top of the file anyways
    so if it's not importable, we won't even reach _check_dependencies.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

- Autogen most of the checked list.
- Replace outdated pydata_sphinx_theme entry.
- matplotlib and its dependency pillow don't need to be explicitly
  listed, as we already import matplotlib at the top of the file anyways
  so if it's not importable, we won't even reach _check_dependencies.
@QuLogic QuLogic merged commit 06b0a6c into matplotlib:main Feb 24, 2022
@anntzer anntzer deleted the cd branch February 24, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants