Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer call draw_if_interactive in parasite_axes. #23156

Merged
merged 1 commit into from May 27, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 27, 2022

This is a remnant of the pre-staleness system, where all pyplot
functions used to call draw_if_interactive to trigger a draw_idle; this
has now been superseded with the stale system which likewise triggers a
draw_idle (here via add_subplot, which marks the figure as stale).

This way, the only remaining places that call draw_if_interactive
internally are in plt.figure() and in figure unpickling.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

This is a remnant of the pre-staleness system, where all pyplot
functions used to call draw_if_interactive to trigger a draw_idle; this
has now been superseded with the stale system which likewise triggers a
draw_idle (here via add_subplot, which marks the figure as stale).

This way, the only remaining places that call draw_if_interactive
internally are in plt.figure() and in figure unpickling.
@tacaswell tacaswell added this to the v3.6.0 milestone May 27, 2022
@oscargus oscargus merged commit 0873285 into matplotlib:main May 27, 2022
@anntzer anntzer deleted the udif branch May 27, 2022 20:58
andrew-fennell pushed a commit to andrew-fennell/matplotlib that referenced this pull request Jun 14, 2022
This is a remnant of the pre-staleness system, where all pyplot
functions used to call draw_if_interactive to trigger a draw_idle; this
has now been superseded with the stale system which likewise triggers a
draw_idle (here via add_subplot, which marks the figure as stale).

This way, the only remaining places that call draw_if_interactive
internally are in plt.figure() and in figure unpickling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants