Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Switch to HTML5 and cleanup CSS #23284

Merged
merged 2 commits into from Jun 18, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 16, 2022

PR Summary

The pydata-sphinx-theme is targeting HTML5, and so we no longer need to fall back to HTML4. Additionally, lots of CSS cruft can be dropped as it styled things that we no longer have.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

The pydata-sphinx-theme is ready, and even optimized for, an HTML5 page.
Additionally, docutils>=0.17 has started using HTML5 semantic tags
already.
These classes were all dropped in 3.5.0, as they were previously on the
front page. I also could not find any mention of `highlighttable` in any
produced documentation.
@QuLogic QuLogic added this to the v3.6.0 milestone Jun 16, 2022
@QuLogic
Copy link
Member Author

QuLogic commented Jun 16, 2022

I don't believe any of the regressions from #13591 have resurfaced due to this.

@timhoffm timhoffm merged commit c9bc943 into matplotlib:main Jun 18, 2022
@QuLogic QuLogic deleted the html-update branch June 20, 2022 22:35
QuLogic added a commit to QuLogic/mpl-sphinx-theme that referenced this pull request Jun 21, 2022
QuLogic added a commit to QuLogic/mpl-sphinx-theme that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants