Fix rectangle and hatches for colorbar #23684
Conversation
There was a problem hiding this comment.
This fix seems correct to fix the shape bug. However, I'll block because It seems better to just leave hatching completely broken, for the horizontal case at least, rather than fix it for a 3.6 with an off-by-one bug? I appreciate the off-by-one bug is in the semi-working vertical colorbar as well, and agree that they both need to be fixed. If anything, I'd remove the hatching completely from the colorbar for 3.6 until there is a proper fix.
|
As per comment in the original issue if this fixes cbars without extends then I withdraw my objection. Obviously we should fix the extends but this is an improvement. I'd add a test with no extends |
jklymak
dismissed
their stale review
Problem just with extends. This fixes non extend cbars properly
oscargus
force-pushed
the
colorbarhatchrectangle
branch
from
5aaf547
to
6322731
Compare
|
I've fixed the extends as well now. |
| def test_colorbar_contourf_extend_patches(): | ||
| params = [ | ||
| ('both', 5, ['\\', '//']), | ||
| ('min', 7, ['+']), |
There was a problem hiding this comment.
This may seem stupid, but this did actually break at one stage as hatches wasn't extended enough.
| cs = ax.contourf(x, y, z, levels, hatches=hatches, | ||
| cmap=cmap, extend=extend) | ||
| fig.colorbar(cs, ax=ax, orientation=orientation, fraction=0.4, | ||
| extendfrac=0.2, aspect=5) |
There was a problem hiding this comment.
"Oversized" colorbar so that hatches are visible.
oscargus
changed the title
|
Moved to 3.6.1 since this is a bug fix, even if its an old bug? |
|
I'll try to update this over the weekend. Had forgotten about the comments... |
oscargus
force-pushed
the
colorbarhatchrectangle
branch
from
6322731
to
d472042
Compare
oscargus
force-pushed
the
colorbarhatchrectangle
branch
from
d472042
to
f521589
Compare
oscargus
force-pushed
the
colorbarhatchrectangle
branch
from
f521589
to
9576ab3
Compare
…684-on-v3.6.x Backport PR #23684 on branch v3.6.x (Fix rectangle and hatches for colorbar)
PR Summary
Closes #23456.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).