Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version switcher links #23835

Merged
merged 1 commit into from Sep 9, 2022
Merged

Fix version switcher links #23835

merged 1 commit into from Sep 9, 2022

Conversation

melissawm
Copy link
Contributor

PR Summary

The links listed in the version switcher switcher.json file are missing a trailing slash, creating broken links.

Closes #23794

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be working in the rendered docs? OTOH this looks right to me.

@melissawm
Copy link
Contributor Author

No unfortunately it will only work after it is merged because the switcher.json file is only read from a URL but not locally.

@QuLogic
Copy link
Member

QuLogic commented Sep 9, 2022

The file is blocked by CORS; I've added a temporary exception to allow it on the server.

@QuLogic
Copy link
Member

QuLogic commented Sep 9, 2022

Ah, but of course, that won't fix it here since it's not yet on the server.

@QuLogic QuLogic added this to the v3.7.0 milestone Sep 9, 2022
@QuLogic QuLogic merged commit 5f647cb into matplotlib:main Sep 9, 2022
@QuLogic
Copy link
Member

QuLogic commented Sep 9, 2022

It appears to be working again, though you might need a full refresh to pick up the new switcher.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Version switcher broken in devdocs
3 participants