Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out error generation for function calls with wrong nargs. #24447

Merged
merged 1 commit into from Nov 14, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 14, 2022

... matching the wording for standard functions.

Note that nargs_error returns the exception without raising it itself to
make the control flow clearer on the caller side.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

lib/matplotlib/axes/_axes.py Outdated Show resolved Hide resolved
@ksunden
Copy link
Member

ksunden commented Nov 14, 2022

Test for quiver nargs matches against that portion of the string, and thus must be updated

... matching the wording for standard functions.

Note that nargs_error returns the exception without raising it itself to
make the control flow clearer on the caller side.
@anntzer
Copy link
Contributor Author

anntzer commented Nov 14, 2022

oops, fixed, thanks.

@timhoffm timhoffm merged commit 8d2d4c2 into matplotlib:main Nov 14, 2022
@timhoffm timhoffm added this to the v3.7.0 milestone Nov 14, 2022
@anntzer anntzer deleted the nargs_error branch November 14, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants