Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggling layout engines #24924

Merged
merged 1 commit into from Jan 10, 2023
Merged

Fix toggling layout engines #24924

merged 1 commit into from Jan 10, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 10, 2023

PR Summary

Re-uses the tests from #22849, but also tests that going back on works as well.

Fixes #22847

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works
as well.

Fixes matplotlib#22847

Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
@QuLogic QuLogic added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label Jan 10, 2023
@QuLogic QuLogic added this to the v3.7.0 milestone Jan 10, 2023
@jklymak jklymak merged commit e0dc18d into matplotlib:main Jan 10, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 10, 2023
@QuLogic QuLogic deleted the layout-toggles branch January 10, 2023 23:43
QuLogic added a commit that referenced this pull request Jan 10, 2023
…924-on-v3.7.x

Backport PR #24924 on branch v3.7.x (Fix toggling layout engines)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot toggle set_tight_layout
3 participants