Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire deprecations from 3.6 #24984

Merged
merged 35 commits into from Mar 8, 2023
Merged

Expire deprecations from 3.6 #24984

merged 35 commits into from Mar 8, 2023

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Jan 14, 2023

PR Summary

Not all, but most (all?) of the ones I understood (quite) easily...

Split into multiple commits for somewhat sensible commit messages. Will add an api-change note.

The first commit also improves the argument checking of (set_)pickradius slightly.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus added this to the v3.8.0 milestone Jan 14, 2023
@oscargus oscargus force-pushed the pickradius branch 4 times, most recently from dbb0c54 to f97e5f5 Compare January 14, 2023 15:14
@@ -575,7 +575,7 @@ default. The default face color is now ``'C0'`` instead of ``'b'``.
ax_bottom.set_ylim(0, .75)
ax_bottom.add_artist(mpatches.Rectangle(grid[1] - [0.025, 0.05],
0.05, 0.1))
ax_bottom.add_artist(mpatches.RegularPolygon(grid[3], 5, 0.1))
Copy link
Contributor Author

@oscargus oscargus Jan 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would have expected this to warn earlier?

Edit: it did warn, but it seems like the doc-build didn't pick it up.

@efiring
Copy link
Member

efiring commented Jan 16, 2023

Thank you for doing this. I read through the file diffs without finding any problems. I did not try to match every removal with a note in the changes/removals file, but I did notice that removals from the backends don't seem to be mentioned there.

@oscargus
Copy link
Contributor Author

Ahh, you are correct. Well spotted!

In the 3.6 documents it was a big list of all the backend changes, but I didn't touch the interactive ones, so at the time I just skipped that for later and forgot about it...

@oscargus
Copy link
Contributor Author

This is now added.

Note that some of the things didn't have deprecation notices in the 3.6 docs, such as positional argument renaming.

lib/matplotlib/mlab.py Outdated Show resolved Hide resolved
@oscargus
Copy link
Contributor Author

oscargus commented Mar 6, 2023

Thanks @anntzer ! Should be sorted out now.

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postci

lib/matplotlib/offsetbox.py Outdated Show resolved Hide resolved
Copy link
Member

@ksunden ksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only hard blocker is the offsetbox kw-only arg position, but also commented on collections version of pickradius if you wish to make that consistent with some other pickradus implementations

@oscargus
Copy link
Contributor Author

oscargus commented Mar 7, 2023

Thanks @ksunden ! Good finds!

@ksunden ksunden merged commit c9bd855 into matplotlib:main Mar 8, 2023
@oscargus oscargus deleted the pickradius branch March 8, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants