Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with shared log axis #24991

Merged
merged 1 commit into from Mar 30, 2023
Merged

Conversation

oscargus
Copy link
Contributor

Co-authored-by: Antony Lee anntzer.lee@gmail.com

PR Summary

Closes #14527

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

lib/matplotlib/ticker.py Outdated Show resolved Hide resolved
@oscargus
Copy link
Contributor Author

The question here is if this should go into 3.7 and if so, if it should go as is (to be modified in 3.8 to use _get_shared_axis()) or if #24983 should go in 3.7 as well.

@oscargus
Copy link
Contributor Author

I checked 'symlog' and 'logit' and the original issue is not there.

@oscargus oscargus added this to the v3.8.0 milestone Mar 12, 2023
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly modulo @greglucas's suggestion to check axis limits explicitly instead of an image test.

Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
@oscargus
Copy link
Contributor Author

Now checking the limits (and tick-locations).

(I wonder why the "Need rebase" label was not added automatically?)

@greglucas greglucas merged commit 92a0ffc into matplotlib:main Mar 30, 2023
37 checks passed
@oscargus oscargus deleted the sharedlogaxis branch March 31, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log scale messed up in histograms when sharing axes
5 participants