New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NumPy to 1.21 #24992
Bump NumPy to 1.21 #24992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the numpy support date the relevant number?
We state (https://matplotlib.org/stable/devel/min_dep_policy.html):
All minor versions of numpy released in the 24 months prior to the project, and at minimum the last three minor versions.
1.21.6 was released on 12. Apr. 2022 (https://pypi.org/project/numpy/#history) so we cannot bump to 1.22 before Apr. 2024.
But I think we can bump to 1.21. The last 1.20.x release was in May 2021.
I was under the impression that we followed NEP29 and that interpretation: "On Jun 23, 2023 drop support for NumPy 1.21 (initially released on Jun 22, 2021)" However, the formulation is slightly different there: "all minor versions of NumPy released in the prior 24 months from the anticipated release date with a minimum of 3 minor versions of NumPy." I'll put into draft until the dev call on Thursday. |
I'm not clear either how the statement is to be understood. Please clarify in the call on Thursday. Anybody can dismiss my comment afterwards. |
38a9c76
to
db8ae89
Compare
From devcall: it is the first version, so strictly we can go with 1.22. However, as the next release is expected around June 23, we shouldn't really push it, so makes sense to go with 1.21. |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR Summary
I assume that 3.8 will not be released before June 23...
https://numpy.org/neps/nep-0029-deprecation_policy.html
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst