Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NumPy to 1.21 #24992

Merged
merged 2 commits into from Jan 20, 2023
Merged

Bump NumPy to 1.21 #24992

merged 2 commits into from Jan 20, 2023

Conversation

oscargus
Copy link
Contributor

PR Summary

I assume that 3.8 will not be released before June 23...

https://numpy.org/neps/nep-0029-deprecation_policy.html

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus added Maintenance PR: dependencies Pull requests that update a dependency file labels Jan 15, 2023
@oscargus oscargus added this to the v3.8.0 milestone Jan 15, 2023
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the numpy support date the relevant number?

We state (https://matplotlib.org/stable/devel/min_dep_policy.html):

All minor versions of numpy released in the 24 months prior to the project, and at minimum the last three minor versions.

1.21.6 was released on 12. Apr. 2022 (https://pypi.org/project/numpy/#history) so we cannot bump to 1.22 before Apr. 2024.

But I think we can bump to 1.21. The last 1.20.x release was in May 2021.

@oscargus
Copy link
Contributor Author

I was under the impression that we followed NEP29 and that interpretation:

"On Jun 23, 2023 drop support for NumPy 1.21 (initially released on Jun 22, 2021)"

However, the formulation is slightly different there:

"all minor versions of NumPy released in the prior 24 months from the anticipated release date with a minimum of 3 minor versions of NumPy."

I'll put into draft until the dev call on Thursday.

@oscargus oscargus marked this pull request as draft January 17, 2023 09:59
@timhoffm
Copy link
Member

I'm not clear either how the statement is to be understood. Please clarify in the call on Thursday. Anybody can dismiss my comment afterwards.

@oscargus oscargus force-pushed the numpy122 branch 2 times, most recently from 38a9c76 to db8ae89 Compare January 19, 2023 20:26
@oscargus oscargus changed the title Bump NumPy to 1.22 Bump NumPy to 1.21 Jan 19, 2023
@oscargus
Copy link
Contributor Author

From devcall: it is the first version, so strictly we can go with 1.22. However, as the next release is expected around June 23, we shouldn't really push it, so makes sense to go with 1.21.

@oscargus oscargus marked this pull request as ready for review January 19, 2023 20:30
@oscargus oscargus dismissed timhoffm’s stale review January 19, 2023 20:45

Question has been answered.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm merged commit 3696e06 into matplotlib:main Jan 20, 2023
@oscargus oscargus deleted the numpy122 branch January 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants