New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure TwoSlopeNorm always has two slopes #25061
Conversation
Wouldn't it be better to just error out here? |
Given this is in the autoscaling part (the user hasn't explicitly requested a vmin/vmax), I'd say it's better to choose some sensible vmin/vmax and give the user some sort of plot - if they then want to change the vmin/vmax that's at least a starting point to go from. |
This needs atleast a whats new |
This seems good to me after a bit of documentation. Ping for a review if it gets buried |
Added a behaviour change note as I didn't think this warranted a what's new - happy to add or move to what's new though if anyone disagrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks, and sorry for misunderstanding the intention.
Restarted the failed job, looked unrelated (a subprocess call for blitting with tk). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone can merge on green.
PR Summary
Fixes #24283.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst