Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly pass valinit as keyword in SliderTool. #25098

Merged
merged 1 commit into from Jan 28, 2023
Merged

Correctly pass valinit as keyword in SliderTool. #25098

merged 1 commit into from Jan 28, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 27, 2023

valinit is becoming keyword-only.

It's not really clear why the warning is getting suppressed e.g. with the tk backend, though.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Correctly pass valinit as keyword in SliderTool.
3a6c374 
valinit is becoming keyword-only.

It's not really clear why the warning is getting suppressed e.g. with
the tk backend, though.
@anntzer anntzer added this to the v3.7.0 milestone Jan 27, 2023
@dstansby dstansby merged commit 546b9fc into matplotlib:main Jan 28, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 28, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 28, 2023
@dstansby @meeseeksmachine
Backport PR matplotlib#25098: Correctly pass valinit as keyword in Sl…
b7b2e44 
…iderTool.
@anntzer anntzer deleted the slidervalinitkw branch January 28, 2023 10:39
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anntzer @ksunden @dstansby