Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tk blitting to destroyed canvases should be a noop, not a segfault. #25104

Merged
merged 1 commit into from Jan 30, 2023
Merged

tk blitting to destroyed canvases should be a noop, not a segfault. #25104

merged 1 commit into from Jan 30, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 28, 2023 •
edited

Choosing to noop (rather than erroring) is consistent with other backends.

Closes #16580, closes #23809.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
tk blitting to destroyed canvases should be a noop, not a segfault.
91f6f6c 
Choosing to noop (rather than erroring) is consistent with other
backends.
@jklymak jklymak merged commit 1ad6cbf into matplotlib:main Jan 30, 2023
@anntzer anntzer deleted the tkc branch January 30, 2023 22:58
@QuLogic QuLogic added this to the v3.8.0 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v3.8.0
4 participants
@anntzer @jklymak @ksunden @QuLogic