Increase timeout to GitHub API #25151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 4, 2023
|
Can be self-merged after deciding whether to backport. |
|
Should we not use the fallback data always? It seems a little weird to be calling a url to populate an example. |
dstansby
approved these changes
Feb 4, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 4, 2023
ksunden
added a commit
that referenced
this pull request
Feb 5, 2023
…151-on-v3.7.x Backport PR #25151 on branch v3.7.x (Increase timeout to GitHub API)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Just realized that https://matplotlib.org/stable/gallery/lines_bars_and_markers/timeline.html often seems to time out so that the fallback data is used. Even locally, 0.4 seems to not be enough. Increasing to 1 which at least locally seems to do the trick.
Edit: Seems to work better now https://output.circle-artifacts.com/output/job/1146acc6-be05-4922-a20e-a5622d444218/artifacts/0/doc/build/html/gallery/lines_bars_and_markers/timeline.html
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst