Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: explain how to make a fixed-size axes #25195

Merged
merged 1 commit into from Feb 16, 2023

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Feb 10, 2023

PR Summary

Also added some facecolor to some of the figures that could use it.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@jklymak jklymak marked this pull request as draft February 10, 2023 21:45
@jklymak jklymak force-pushed the doc-fixed-size branch 2 times, most recently from 69765fd to bf392d0 Compare February 10, 2023 21:48
@jklymak jklymak added this to the v3.7.1 milestone Feb 10, 2023
@jklymak jklymak changed the title DOC: explain how ot make a fixed-size axes DOC: explain how to make a fixed-size axes Feb 10, 2023
@jklymak jklymak force-pushed the doc-fixed-size branch 2 times, most recently from 789fd4d to 78f9705 Compare February 10, 2023 23:50
@jklymak jklymak marked this pull request as ready for review February 11, 2023 00:25
@rcomer
Copy link
Member

rcomer commented Feb 11, 2023

Huh. I didn’t know you could pass a position into add_subplot, and would have expected this example to use add_axes. Even now I know, the docstring is confusing: pos is listed in the valid call signatures, but not described under parameters.

So is add_axes redundant api or is there some difference in what you would get?

@jklymak
Copy link
Member Author

jklymak commented Feb 11, 2023

Switched to add_axes. I actually meant to do that originally.

I don't understand why CI is running. I thought the Actions check would work here...

@jklymak jklymak modified the milestones: v3.7.1, v3.7-doc Feb 13, 2023
@jklymak
Copy link
Member Author

jklymak commented Feb 16, 2023

@rcomer is this OK now?

@rcomer rcomer merged commit 50fc5dd into matplotlib:main Feb 16, 2023
@QuLogic QuLogic modified the milestones: v3.7-doc, v3.8.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants