Fix for all NANs in contour #25334
Fix for all NANs in contour #25334
Conversation
|
How does the original issue behave with this change? (Maybe you can add the smoke test back?) |
I'm getting the following output with all NAN : Yes, I'll add the tests. (we're not getting any masking errors this time) |
|
Do you also want to change the |
|
done @greglucas, PTAL |
lib/matplotlib/tests/test_contour.py
Outdated
|
|
||
| def test_all_nan(): | ||
| x = np.array([[np.nan, np.nan], [np.nan, np.nan]]) | ||
| assert_array_almost_equal(plt.contour(x).levels.tolist(), |
There was a problem hiding this comment.
I'm pretty sure numpy's testing will compare the list and levels array for you, so I don't think you need to convert it to a list here unless you were doing the bare assert like above.
| assert_array_almost_equal(plt.contour(x).levels.tolist(), | |
| assert_array_almost_equal(plt.contour(x).levels, |
There was a problem hiding this comment.
Yeah right, removed to_list conversion. Thanks.
|
Thanks @xtanion and congratulations on your first merged PR in Matplotlib! Hope to see you around! |
PR Summary
As discussed in #25330, we're removing the typecase to float with
z.min().astype(float).Closes #14124.