Move _SelectorWidget._props into SpanSelector #25404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of storing _props in a separate dict at all, can't the artist re-creation call Artist.update_from to copy the original artist's properties? |
|
I just forgot about that; should work that way now. |
anntzer
reviewed
Mar 8, 2023
This was the only selector widget that needed to remember its properties separately from the artist, because the artist can be recreated, but we can copy from the old to new. Fixes matplotlib#25199
There are already a few for the other Selectors.
anntzer
approved these changes
Mar 8, 2023
greglucas
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is the only selector widget that needs to remember its properties separately from the artist, because the artist can be recreated.
Fixes #25199
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst