Deprecate tostring_rgb. #25484
Merged
Deprecate tostring_rgb. #25484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted previously, silently dropping alpha can be confusing. Also, directly accessing the buffer array is more efficient (it does not involve copying to a string buffer) and should cover most use cases.
oscargus
approved these changes
Mar 17, 2023
jklymak
reviewed
Mar 17, 2023
| @@ -414,6 +415,7 @@ def get_renderer(self, cleared=False): | |||
| self.renderer.clear() | |||
| return self.renderer | |||
|
|
|||
| @_api.deprecated("3.8") | |||
There was a problem hiding this comment.
Do we need any of these tostring_ methods? and even if we do, should they not be private?
There was a problem hiding this comment.
We could also deprecate tostring_argb (which we don't use either anymore); I don't have a strong opinion here.
ksunden
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted previously (#5336, see in particular the comments in the thread), silently dropping alpha can be confusing. Also, directly accessing the buffer array is more efficient (it does not involve copying to a string buffer) and should cover most use cases.
Closes #5336.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst